Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix missing badges in policy table #194

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

lupusA
Copy link
Collaborator

@lupusA lupusA commented Sep 23, 2023

Hi,

this PR fixes #3343 that indicates that some policy badges are missing. These badges indicate an individual setting of policies.

  • Badges are now created in a loop, looping over all policy settings that have been changed
  • Badges are now styled according to the primary color of the theme

This is how it should look:
image

Feedback is welcomed.

Cheers,

Copy link
Contributor

@jkowalski jkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lupusA
Copy link
Collaborator Author

lupusA commented Sep 24, 2023

Hi @jkowalski,

i am just fixing the isEmpty() function and then the pr is ready for review. The function returns logging in all policies, even though nothing is changed.

Cheers,

@lupusA lupusA marked this pull request as ready for review September 25, 2023 18:36
@jkowalski jkowalski merged commit 0bb1ebc into kopia:main Sep 25, 2023
2 checks passed
lupusA added a commit to lupusA/htmlui that referenced this pull request Sep 27, 2023
* Fix missing badges in policies

* Childs now have unique key in list

* Added isEmptyObject()

---------

Co-authored-by: Christoph Anderson <[email protected]>
@lupusA lupusA deleted the fix-missing-badges-in-policies branch September 30, 2023 10:16
jkowalski pushed a commit that referenced this pull request Oct 10, 2023
* - Fixed the badge colors
- Badge colors are now dependend on the theme

* fix(ui): Fix missing badges in policy table (#194)

* Fix missing badges in policies

* Childs now have unique key in list

* Added isEmptyObject()

---------

Co-authored-by: Christoph Anderson <[email protected]>

* Started to refactor css

* Further refactoring of the css file

* Deleted obsolet css statements

* Adjusting colors and refactor css

* Dummy commit

* Further refactoring. Properly overriding bootstrap

* Minor refactoring

---------

Co-authored-by: Christoph Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policytable "Defined" column misses some categories
2 participants